Revert "CIG: Fix CIG parameters for unidirectional CIS"#960
Open
uier wants to merge 2 commits into
Open
Conversation
zxzxwu
approved these changes
Jul 13, 2026
Collaborator
|
Even if it is ignored, maybe we can still set rtn_c_to_p and/or rtn_p_to_c to 0 (leaving phy unchanged), for maximum compatibility with controllers that are a bit too picky? |
a3ba5e7 to
8b2bd06
Compare
Collaborator
Author
Sounds good, changed to this way |
Collaborator
Author
|
I've found that the Intel BE200 is raising 0x30 if the unused direction is not setting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #943
which was trying to fix a HCI error
PARAMETER_OUT_OF_MANDATORY_RANGE_ERROR [0x30]raised by a Bluetooth controller when receiving parameters from a CIS creation.Based on the Spec about
LE Set CIG Parameters command:We should not assign 0 to PHY for any direction even if it's unidirectional CIS on the other direction.
This is ignored when it's unidirectional CIS on the other direction, but that specific controller doesn't satisfy if this is set to zero, but it also needs to set PHY to zero, which doesn't sound right and should file ticket to check with the vendor, instead of putting the wrong fix here.